Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6756 closed enhancement (fixed)

Rename _alloc() to _new()

Reported by: ln5 Owned by:
Priority: Very Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

See the following commits in branch misc of my public repo:

45e5e0f5 * misc Rename packed_cell_alloc() --> _new().
dbe2120d * Rename config_alloc() --> _new().
9b41dd55 * linus/misc Rename extend_info_alloc() --> _new().

Leaving memarea_alloc() untuched. It's not allocating an "object" like the others.

Child Tickets

Change History (7)

comment:1 Changed 7 years ago by ln5

Status: newneeds_review

comment:2 Changed 7 years ago by nickm

I agree with this, but I think that your IPv6 branch also touches one of the blocks that calls extend_info_alloc. If that's so, I want to hold off merging this until after that's merged, to avoid conflicts.

comment:3 in reply to:  2 Changed 7 years ago by ln5

Replying to nickm:

I agree with this, but I think that your IPv6 branch also touches one of the blocks that calls extend_info_alloc. If that's so, I want to hold off merging this until after that's merged, to avoid conflicts.

Indeed it does. This can wait.

Thanks.

comment:4 Changed 7 years ago by ln5

Branch renamed to bug6756.

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Cherry-picked the first two commits; recreated the third. Thanks!

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.