Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6759 closed defect (implemented)

Don't tell user about reloading microdesc cache at startup

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: #6736 Points:
Reviewer: Sponsor:

Description

Sep 03 18:12:41.000 [notice] Reloaded microdescriptor cache.  Found 0 descriptors.

is there on initial startup every time.

If you've already got lots of dir info, it would say e.g.

Sep 03 18:24:41.000 [notice] Reloaded microdescriptor cache.  Found 3035 descriptors.

Our bootstrap warnings are supposed to tell the user when there's a problem, and our bootstrap notices say when there isn't. We don't need this extra line.

I had originally thought to do a fancier fix like:

-  log_notice(LD_DIR, "Reloaded microdescriptor cache.  Found %d descriptors.",
-             total);
+  log(total ? LOG_NOTICE : LOG_INFO, LD_DIR,
+      "Reloaded microdescriptor cache. Found %d descriptors.", total);

but then I noticed that 0.2.2.38 doesn't have a line about loading descriptors, so I have tentatively marked this as 0.2.3.x-final and suggest just downgrading the log message.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by arma

Status: newneeds_review

See my bug6759 branch.

comment:2 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

I want to call this 0.2.4.x. The existing message isn't actually hurting anybody in 0.2.3.x, though it is indeed a bit pointless.

Merging to master and closing; please reopen if you really think it should go into 0.2.3 and make weasel sad.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.