Opened 8 years ago

Closed 3 years ago

#6762 closed defect (fixed)

Make Atlas more robust to inconsistent Onionoo replies

Reported by: karsten Owned by: irl
Priority: Low Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords: metrics-2018
Cc: nusenu@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When Onionoo lists a relay in its summary document but doesn't have a details document for that relay, Atlas will run into a "TypeError: relay is undefined" in js/models/relay.js in $.getJSON() in the lookup function. The effect is that Atlas shows "undefined" in its results. The fix is for Atlas to not rely on Onionoo always having a details document. (The other fix is to make Onionoo not return inconsistent replies, but that's something that the database-based Pyonionoo will fix.)

Child Tickets

#21658closedirlDo not attempt to plot graphs when the actual request for bandwidth data failedMetrics/Relay Search

Change History (8)

comment:1 Changed 6 years ago by tyseom

Cc: nusenu@… added

comment:2 Changed 4 years ago by karsten

Severity: Normal
Status: newneeds_information

I believe this issue will irrelevant after implementing #19452. Setting to needs_information until that other ticket is implemented, after which we should reconsider also closing this one.

comment:3 Changed 4 years ago by irl

Status: needs_informationnew

As we decided not to implement #19452, this will still need to be looked at independently.

comment:4 Changed 4 years ago by karsten

This is somewhat related to #21658.

comment:5 Changed 3 years ago by karsten

Keywords: metrics-2018 added

comment:6 Changed 3 years ago by karsten

Owner: changed from hellais to metrics-team
Status: newassigned

comment:7 Changed 3 years ago by irl

Owner: changed from metrics-team to irl
Status: assignedaccepted

Moving these into my queue.

comment:8 Changed 3 years ago by irl

Resolution: fixed
Status: acceptedclosed

All optional fields are initialised to null if they are not present in the Onionoo document and we did switch to making a single request for the Onionoo data when performing searches, so I believe this to be fixed.

Note: See TracTickets for help on using tickets.