Opened 7 years ago

Closed 6 years ago

#6805 closed defect (implemented)

Restore consensus-governed path bias messages

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: 023backport needs-proposal tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The log line for the check against pathbias_get_notice_rate() in entry_guard_inc_first_hop_count() should not have been demoted to info level. We have a consensus parameter to govern it if it really gets out of hand. It can be fully disabled using this parameter, just like the warn message can be and is. The warn should not have been demoted either.

I'm setting this as 'major' based on #6537's priority. I don't believe it is rational to merge #6537 and #6538 into 0.2.2.x and 0.2.3.x without also informing the user about the possibility a significantly more serious active attack.

I can fix the log message to be less threatening as part of this. I would also like to do this commit on top of the #6647 backport.

Child Tickets

Change History (7)

comment:1 Changed 7 years ago by nickm

Keywords: needs-proposal added
Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

comment:2 Changed 7 years ago by mikeperry

Keywords: MikePerry201210d added; MikePerry201209 removed

I'll wrap the 0.2.3.x log message promotion ideas into the #6135 proposal. The log messages will be key to understanding the effects of our chosen values in the field.

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:5 Changed 7 years ago by mikeperry

Keywords: MikePerry201210d removed

Probably want #7157 and #7281 before considering backporting this.

comment:6 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

Bumping to 0.2.5; feels backportable.

comment:7 Changed 6 years ago by mikeperry

Resolution: implemented
Status: newclosed

This logline is notice in 0.2.4.x, which is almost stable now.

Note: See TracTickets for help on using tickets.