Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#6823 closed defect (implemented)

Refactor config_fmt_t and or_state_t code out of config.c

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: #6837 Points:
Reviewer: Sponsor:


Step one of a nicer config.c is to start yanking out the parts that aren't strictly speaking related to configuration. The big chunks there are the or_state_t code and the generic configuration parser code.

Splitting out the generic configuration parser code will also help my sinister plan (#6802) to make configuration parsing nicer.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by nickm

Status: newneeds_review

See my branch confparse_refactor for the code. It's pretty big, but only because it's moving code.

comment:2 Changed 8 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Still looks okay to me. Squashed and merged.

comment:3 Changed 8 years ago by nickm

Parent ID: #6802#6837

comment:4 Changed 8 years ago by nickm

Keywords: tor-client added

comment:5 Changed 8 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.