Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6830 closed defect (fixed)

Bogus comment in src/or/crypto.h

Reported by: rransom Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

From src/or/crypto.h:

/** Length of the output of our second (improved) message digests.  (For now
 * this is just sha256, but any it can be any other 256-byte digest). */
#define DIGEST256_LEN 32

(a) s/but any it/but it/
(b) No, it can't be.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Easier to fix than mark as 'easy' and having the next person guess what (b) above meant (s/byte/bit/, I assume). Committed cf182efe0d026273fcea48321e30b29279e99de3

comment:2 Changed 7 years ago by rransom

SHA-256 cannot be replaced with some other 256-bit digest algorithm without a major protocol change.

comment:3 Changed 7 years ago by nickm

Right, but if it is, the length of the output will still be DIGEST256_LEN.

comment:4 Changed 7 years ago by nickm

Keywords: tor-client added

comment:5 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.