Opened 7 years ago

Last modified 22 months ago

#6837 new enhancement

More fine-grained modular decomposition

Reported by: nickm Owned by:
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.2.7
Severity: Normal Keywords: tor-relay, tor-modularity refactoring code-movement technical-debt
Cc: Actual Points:
Parent ID: Points: parent
Reviewer: Sponsor: SponsorS-can

Description (last modified by nickm)

We should chop up our huger C files into smaller ones, based on actual module boundaries.

This will make it harder for us to merge pending branches that touch that code, but those are at a low ebb right now, so it's a good time.

The top 10 offenders in our current codebase are:

   4614 src/or/rendservice.c
   4839 src/or/channel.c
   5200 src/or/connection.c
   5386 src/or/or.h
   5648 src/common/util.c
   5666 src/or/directory.c
   5688 src/or/routerparse.c
   5771 src/or/routerlist.c
   7223 src/or/control.c
   8006 src/or/config.c

(updated May 2017)

Child Tickets

TicketTypeStatusOwnerSummary
#6823defectclosedRefactor config_fmt_t and or_state_t code out of config.c
#6836enhancementclosednickmChop functionality out of routerlist.c
#6838enhancementclosedPull guard and bridge logic out of circuitbuild.c
#6839defectclosedPull statistics and tracking code out of circuitbuild.c

Change History (28)

comment:1 Changed 6 years ago by nickm

Keywords: tor-relay added

comment:2 Changed 6 years ago by nickm

Component: Tor RelayTor

comment:3 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.7.x-final

These may be worth looking at for 0.2.7.

comment:6 Changed 4 years ago by nickm

Status: newassigned

comment:7 Changed 4 years ago by nickm

Keywords: 027-triaged-1-in added

Marking some tickets as triaged-in for 0.2.7 based on early triage

comment:8 Changed 4 years ago by isabela

Keywords: SponsorS added
Points: large
Priority: normalmajor
Version: Tor: 0.2.7

comment:9 Changed 4 years ago by nickm

Milestone: Tor: 0.2.7.x-finalTor: 0.2.8.x-final

comment:10 Changed 3 years ago by nickm

Keywords: 028-triaged added

comment:11 Changed 3 years ago by nickm

Keywords: SponsorS removed
Sponsor: SponsorS

Bulk-replace SponsorS keyword with SponsorS sponsor field in Tor component.

comment:12 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final
Owner: set to nickm

It is impossible that we will fix all 234 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the accepted and assigned tickets in my name, looking for things to move to 0.2.9.

comment:13 Changed 3 years ago by nickm

Owner: nickm deleted

comment:14 Changed 3 years ago by nickm

Sponsor: SponsorSSponsorS-can

comment:15 Changed 3 years ago by nickm

Owner: set to nickm

comment:16 Changed 3 years ago by nickm

Keywords: tor-modularity added

comment:17 Changed 3 years ago by isabela

Points: large6

comment:18 Changed 3 years ago by nickm

Points: 6parent
Severity: Normal

comment:19 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???
Owner: nickm deleted

Dropping this out of 0.2.9, though I hope my module-mangling tools will make this infinitely easier in the future.

comment:20 Changed 3 years ago by nickm

Status: assignednew

comment:21 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:22 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:23 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:24 Changed 22 months ago by nickm

Keywords: 027-triaged-in added

comment:25 Changed 22 months ago by nickm

Keywords: 027-triaged-in removed

comment:26 Changed 22 months ago by nickm

Keywords: 027-triaged-1-in removed

comment:27 Changed 22 months ago by nickm

Keywords: 028-triaged removed

comment:28 Changed 22 months ago by nickm

Description: modified (diff)
Keywords: refactoring code-movement technical-debt added
Note: See TracTickets for help on using tickets.