Pull guard and bridge logic out of circuitbuild.c

Maintaining our list of guard nodes and bridges is functionally separable from the rest of what circuitbuild.c does ; we can pull it out and put it in a new guardnodes.c or entrynodes.c module.

(Not doing this yet since the pending #6465 (moved) touches circuitbuild.c)

changed milestone to %Tor: 0.2.4.x-final

added component::core tor/tor milestone::Tor: 0.2.4.x-final parent::6837 priority::medium resolution::fixed status::closed tor-client type::enhancement labels

Trac:
Actualpoints: #6837 (moved) to N/A
Parent: N/A to #6837 (moved)

A fine idea.

Is it worth separating a bridges.c out of the rest of the entry guard stuff? They sort of overlap, but some parts of them don't.

I think entrynodes.c is slightly better than guardnodes.c, since ... wait, I guess we could just put the 'if you're using guards' logic into that file. In which case maybe guards.c is better?

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

I pulled a ~2000 line chunk of circuitbuild.c out into entrynodes.c in branch "split_circuitbuild". Could use a review.

That branch also includes the split in #6839 (moved)

Trac:
Status: new to needs_review

I think that looks okay to me; you just pulled stuff out into entrynodes.c and circuitstats.c but didn't modify the code in the process, I presume?

That's right. I don't believe I changed any code, other than making a few formerly static things not, and adding some #includes.

Thanks for the review; merging this to master.

Ugh; merge conflict in circuitbuild.c. This could take a little...

There. Wasn't so hard as I'd feared.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #6839 (moved)

moved to tpo/core/tor#6838 (closed)