Opened 7 years ago

Closed 7 years ago

#6839 closed defect (fixed)

Pull statistics and tracking code out of circuitbuild.c

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: #6837 Points:
Reviewer: Sponsor:

Description

Circuit build timeout logic and path bias tracking is functionally separable from the rest of what circuitbuild.c does ; we can pull it out and put it in a new guardnodes.c or entrynodes.c module.

(Not doing this yet since the pending #6465 touches circuitbuild.c)

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client added

comment:2 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:3 Changed 7 years ago by nickm

Status: newneeds_review

I pulled a ~1500 line chunk of circuitbuild.c out into circuitstats.c in branch "split_circuitbuild". Could use a review.

This branch didn't split out the path bias code yet. I'd argue for giving that its own file.

That branch also includes the split in #6838 . With those two, circuitbuild.c is now less than half its original size.

comment:4 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Oh hey, looks like I merged this in 0.2.4.5-alpha. Closing this ticket.

Note: See TracTickets for help on using tickets.