Opened 7 years ago

Closed 4 years ago

#6852 closed enhancement (implemented)

bridges (especially unpublished ones) should include usage info in their heartbeats

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-bridge SponsorJ 026-triaged-1
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

As part of SponsorJ task 2, we're running some fast unpublished bridges. Since they're unpublished, we have no way to learn how much usage they see. We should at least log them so the operators can send us the log snippets over time.

As a side benefit, logging will help the bridge operators who don't use Vidalia/arm and wonder whether their bridge is being helpful.

Child Tickets

Change History (14)

comment:1 Changed 7 years ago by nickm

Keywords: tor-bridge added

comment:2 Changed 7 years ago by nickm

Component: Tor BridgeTor

comment:3 Changed 6 years ago by arma

Keywords: SponsorJ added

comment:4 Changed 6 years ago by arma

Keywords: tor-bridge, SponsorJtor-bridge SponsorJ

comment:5 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

Bumping to 0.2.5, along with other remaining noncritical enhancements.

comment:6 Changed 6 years ago by asn

Don't we already do this in:

  log_fn(LOG_NOTICE, LD_HEARTBEAT, "Heartbeat: Tor's uptime is %s, with %d "
         "circuits open. I've sent %s and received %s.",
         uptime, count_circuits(),bw_sent,bw_rcvd);

what else would you like to see? Maybe unique IP counter?

comment:7 Changed 6 years ago by arma

I was thinking the output of getinfo status/clients-seen

comment:8 Changed 6 years ago by asn

(I'm currently working on this ticket and testing it on my bridge. Just mentioning it, so that we don't do duplicate work.)

comment:9 Changed 6 years ago by asn

I wrote some code for this:
https://gitweb.torproject.org/user/asn/tor.git/commitdiff/05f8fd2878e1b85822c126c0206f8b8929556868

You can find the code at branch bug6852_bug in https://git.torproject.org/user/asn/tor.git.

Unfortunately, there seems to be a bug somewhere and the counter does not reset after 24 (WRITE_STATS_INTERVAL) hours as it should. It resets after 47 hours or so. I haven't managed to find the bug yet, but I hope to revisit this in a couple of days. I'm posting the branch in case anyone else is interested in working on this till then.

comment:10 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final

comment:11 Changed 5 years ago by nickm

Keywords: 026-triaged-1 added
Status: newneeds_revision

comment:12 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

comment:13 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final

comment:14 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Fixed to be "last 6 hours" (arbitrarily), and merged.

Note: See TracTickets for help on using tickets.