Opened 7 years ago

Closed 7 years ago

#6857 closed task (invalid)

Write Protocol Helpers

Reported by: isis Owned by: isis
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords: ooni
Cc: ioerror Actual Points:
Parent ID: #5869 Points:
Reviewer: Sponsor:

Description

ooni-probe will needs basic protocol helpers for the common protocols, e.g. HTTP, SSH, Tor, etc. Fill in this ticket with more protocols which should have helper function, and create child tickets for them.

Child Tickets

TicketStatusOwnerSummaryComponent
#6858closedhellaisHTTP Protocol HelperArchived/Ooni

Change History (7)

comment:1 Changed 7 years ago by isis

Owner: changed from hellais to isis
Status: newaccepted

comment:2 Changed 7 years ago by hellais

Keywords: ooni_test_helpers added; helpers protocol ooni-probe removed

comment:3 Changed 7 years ago by hellais

Keywords: ooni added; ooni_test_helpers removed

comment:4 Changed 7 years ago by isis

Status: acceptedassigned

comment:5 Changed 7 years ago by isis

Status: assignedaccepted

Not a helper for a specific protocol, but I've been working on the scapy template and some helpers for working with scapy.

Current work is in my 'dev-scapy-tests' branch, and an example of the packet creation helper is here:

https://gitweb.torproject.org/user/isis/ooni-probe.git/blob/db59380e1d68d795d3e4590631e06e27c961154e:/ooni/utils/packet.py

comment:6 in reply to:  5 Changed 7 years ago by hellais

Replying to isis:

Not a helper for a specific protocol, but I've been working on the scapy template and some helpers for working with scapy.

Current work is in my 'dev-scapy-tests' branch, and an example of the packet creation helper is here:

https://gitweb.torproject.org/user/isis/ooni-probe.git/blob/db59380e1d68d795d3e4590631e06e27c961154e:/ooni/utils/packet.py

I am uncertain exactly what the use-case of such decorators should be.

Why would it be preferred to use such a decorator over say:

count = 10
for dst in destinations:
    packets.append(TCP(dst=dst)*count))

I think that having a decorator to do these kinds of operations adds unnecessary complexity.

comment:7 Changed 7 years ago by hellais

Resolution: invalid
Status: acceptedclosed

This ticket is non specific. It should be split up into other tickets that contain useful information to implementing the task.

Note: See TracTickets for help on using tickets.