Opened 8 years ago

Closed 3 years ago

#6879 closed defect (fixed)

dir-spec.txt says “For backward compatibility” without a version number

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


At the beginning of dir-spec.txt §2.1 (‘Router descriptor format’):

   Router descriptors consist of the following items.  For backward
   compatibility, there should be an extra NL at the end of each router

There is no mention of what this is meant to provide backward compatibility with.

Child Tickets

Change History (8)

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.4.x-final

comment:2 Changed 8 years ago by nickm

Keywords: tor-client added

comment:3 Changed 8 years ago by nickm

Component: Tor ClientTor

comment:4 Changed 8 years ago by nickm

Keywords: spec added

Archeology: we added the "extra NL" note for the first time in b6524006044160cd1a5c. Not sure why exactly; that was a long time ago.

comment:5 Changed 8 years ago by nickm

Keywords: tor-spec added; spec removed

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:6 Changed 8 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: unspecified

I tried to figure out why this was, and couldn't. If anybody else wants to try the archeology on it, I'd appreciate it: we weren't too good about tracking issues like this in 2004.

comment:7 Changed 3 years ago by arma

Severity: Normal

Actually, that idea went in earlier, at dbf4780ec37 (on Jun 3 2003), where we added

+Note: The extra newline at the end of the router block is intentional.

Alternatively, you can find that same commit at f40ddfab in tor's git.

I looked through it a bit, to try to decode _router_get_next_token() from way back when.

But I think the simpler answer is that we can stop claiming anything about an extra newline, because it has been a long time indeed since that's been relevant.

comment:8 Changed 3 years ago by arma

Resolution: fixed
Status: newclosed

And, my commit c71d8c98 to dir-spec took out the sentence.

I'm going to close this ticket -- please reopen if there's more to do, or if I did it wrong.

Note: See TracTickets for help on using tickets.