Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6884 closed defect (fixed)

Warning about preferred bridge address lies

Reported by: ln5 Owned by: ln5
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: ipv6 tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When the ClientUseIPv6 option was added (commit e04e1a2e) the logic
for what a preferred OR port is changed. The warning about which OR
port is prefered rewrite_node_address_for_bridge() now may say
confusing things like "Will prefer IPv6 port" and then print an IPv4
port.

The address is correct. The address family, "IPv4" or "IPv6" may be wrong.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by ln5

Status: newneeds_review

Please review branch bug6884 in my puclic repo.

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good; merged. (I added "bugfix on 0.2.4.1-alpha" to the changes file, so arma doesn't need to track down which version introduced the bug himself.)

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.