Opened 7 years ago

Closed 7 years ago

#6887 closed defect (fixed)

Remove v1 directory code

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

router_parse_directory in src/or/routerparse.c is left over from the v1 directory protocol, and is only called by test_dir.c. It's (long past) time to delete it.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by rransom

Summary: Remove router_parse_directory from src/or/routerparse.cRemove v1 directory code

router_parse_runningrouters is also v1-only, and not called anywhere.

There are probably a bunch of structs and typedefs that should be rolled up and tossed with these functions.

comment:2 Changed 7 years ago by nickm

Status: newneeds_review

Good idea, and pretty easy.

dirserv_set_cached_directory should also go away, as should the code to generate and set running-routers documents (anybody besides me remember those?) but first we should make sure that nothing is actually fetching them still, getting ready to dos the authorities if the document goes away.

See initial work in my branch bug6887

comment:3 Changed 7 years ago by nickm

Keywords: tor-client added

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged it.

Note: See TracTickets for help on using tickets.