Opened 7 years ago

Closed 3 years ago

#6899 closed enhancement (duplicate)

Make "OptimisticData auto" mean it's on?

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

static int
optimistic_data_enabled(void)
{
  const or_options_t *options = get_options();
  if (options->OptimisticData < 0) {
    /* XXX023 consider having auto default to 1 rather than 0 before
     * the 0.2.3 branch goes stable. See bug 3617. -RD */
    const int32_t enabled =
      networkstatus_get_param(NULL, "UseOptimisticData", 0, 0, 1);
    return (int)enabled;
  }
  return options->OptimisticData;
}

Has anybody tested it? Should we try turning it on in the consensus to see what breaks? Do any applications use it?

Child Tickets

Change History (6)

comment:1 in reply to:  description Changed 7 years ago by arma

Replying to arma:

Should we try turning it on in the consensus to see what breaks?

Seems like the answer here should be yes, so we can be more likely to learn whether something's broken.

comment:2 Changed 7 years ago by nickm

Keywords: tor-client added

comment:3 Changed 7 years ago by nickm

Component: Tor ClientTor

comment:4 Changed 7 years ago by arma

Status: newneeds_review

see my ticket6899 branch

we turned it on in the consensus three weeks ago, and nothing broke. i think we should make it on by default (rather than off by default but overruled by the consensus)

comment:5 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

We've already got a consensus parameter turning this on in practice. I think that merging the code to make it "on" would be a bad idea, in case (on further testing) it turns out that there is absolutely nothing broken here. Sure, it's been on for a while, but I don't think apps are using it yet , and so I'm a little leery of merging it just now.

comment:6 Changed 3 years ago by nickm

Resolution: duplicate
Severity: Normal
Status: needs_reviewclosed

It turns out we did this, years later, in #18815.

Note: See TracTickets for help on using tickets.