Opened 7 years ago

Closed 7 years ago

#6904 closed defect (fixed)

consensus-health message for ‘conflicting or invalid consensus parameters’ is unclear

Reported by: rransom Owned by: karsten
Priority: Low Milestone:
Component: Metrics Utilities Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

2012-09-20 20:02:14 <nsa> ^Bor^B: [consensus-health] NOTICE: The following directory authorities set conflicting or invalid consensus parameters: maatuska CircuitPriorityHalflifeMsec=30000 UseOptimisticData=1 bwauthpid=1, moria1 CircuitPriorityHalflifeMsec=30000 UseOptimisticData=1 bwauthpid=1, turtles CircuitPriorityHalflifeMsec=30000 UseOptimisticData=1 bwauthpid=1

In this message, the consensus health checker is complaining because it thinks the ‘UseOptimisticData’ parameter is invalid.

This type of message should be split into two messages:

  • one for an ‘invalid’ parameter (usually what this actually means is that consensus-health hasn't been told that a new parameter is valid yet), and
  • one for an actual conflict between parameter values (in which case, it should show the name of the parameter with conflicting values, the values specified by each dirauth which votes on it, and the value produced in the consensus).

Child Tickets

Change History (1)

comment:1 Changed 7 years ago by karsten

Resolution: fixed
Status: newclosed

Split the message into two messages for unknown and conflicting parameters, changed the message texts to only list the actually unknown and/or conflicting parameters, and added UseOptimisticData to the set of known parameters. Closing.

Note: See TracTickets for help on using tickets.