Log early log messages to log files

changed milestone to %Tor: 0.2.6.x-final

added 026-triaged-1 component::core tor/tor milestone::Tor: 0.2.6.x-final nickm-patch parent::10059 priority::high resolution::implemented status::closed tor-client type::defect version::tor 0.2.4.2-alpha labels

Typo. I meant "advertise a DirPort" not "advertise an ORPort".

This happens because Tor puts out that warning while parsing its config, and part of parsing the config is learning what logs the user wants to use. So, there aren't any log files open at that point.

Should we queue "logged stuff" until the log is open, then spit it all out there? That sounds like it could be confusing in the other direction.

Trac:
Component: - Select a component to Tor Client
Description: Issue: When configuring Tor as a bridge and to advertise an ORPort, the resulting warning is displayed on the console, but is not logged to the Tor log file.

Environment: Debian squeeze amd64, latest patches Tor version 0.2.4.2-alpha (git-0537dc6364594474)

How to reproduce: Set "BridgeRelay 1" Set "DirPort 80"

Start Tor.

The following warning will be displayed on the console: "Starting tor daemon... [warn] Can't set a DirPort on a bridge relay; disabling DirPort done."

No corresponding warning is logged to the Tor log file.

to

Issue: When configuring Tor as a bridge and to advertise a DirPort, the resulting warning is displayed on the console, but is not logged to the Tor log file.

Environment: Debian squeeze amd64, latest patches Tor version 0.2.4.2-alpha (git-0537dc6364594474)

How to reproduce: Set "BridgeRelay 1" Set "DirPort 80"

Start Tor.

The following warning will be displayed on the console: "Starting tor daemon... [warn] Can't set a DirPort on a bridge relay; disabling DirPort done."

No corresponding warning is logged to the Tor log file.

Trac:
Priority: trivial to normal
Milestone: N/A to Tor: 0.2.4.x-final

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

Trac:
Priority: normal to major
Milestone: Tor: 0.2.4.x-final to Tor: 0.2.5.x-final

Trac:
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.6.x-final

This is going to 0.2.7; it's not that hard to fix but not trivial - we need a buffering mechanism to save log messages generated early before log files are set up.

Trac:
Milestone: Tor: 0.2.6.x-final to Tor: 0.2.7.x-final
Keywords: tor-client deleted, tor-client 026-triaged-1 added

Trac:
Parent: N/A to #10059 (moved)

The Tor launcher folks want this feature too -- it turns out that the trick we use for running an external binary from a Firefox extension means you can't get at stdout.

If somebody does a patch, we could take it as early as 0.2.6.

The way to do it is like this: on startup, have the log mechanism store every logged message in a structure holding the time, the severity, the log domain, and ...

oh heck, I'll just do it.

(90 minutes later)

See branch "ticket6938" in my public repository. It'll help with logfiles and syslogs, but controllers that want to see early log messages via controller events are still out of luck.

Trac:
Keywords: tor-client 026-triaged-1 deleted, tor-client 026-triaged-1 nickm-patch added
Milestone: Tor: 0.2.7.x-final to Tor: 0.2.6.x-final
Status: new to needs_review

Code looks good to me. Didn't test it though.

It's clean and also cleans out already existing code.

Trac:
Summary: Bridge DirPort warning not logged to Tor log file to Log early log messages to log files

Okay. It still works for me, so merging it. Thanks for the review!

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed

mentioned in issue #10059 (moved)

moved to tpo/core/tor#6938 (closed)

Log early log messages to log files

Child items 0

Activity