Opened 7 years ago

Closed 7 years ago

#6945 closed defect (fixed)

Atlas has no search box

Reported by: rransom Owned by: hellais
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Keywords:
Cc: bastik.public@…, m@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description


Child Tickets

Attachments (2)

17.png (75.4 KB) - added by rransom 7 years ago.
screenshot of the lack of box
photo.PNG (75.4 KB) - added by mno 7 years ago.
screenshot on iPhone

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by rransom

Attachment: 17.png added

screenshot of the lack of box

comment:1 Changed 7 years ago by rransom

See the attached screenshot.

comment:2 Changed 7 years ago by bastik

Cc: bastik.public@… added

There's a button with three stripes. When it gets clicked it reveals "Home", "About" and "Search" (a search box).

I did not saw the button unless I resized the browser window from maximize to something smaller. (For me it's lower than half the screen)

There's even an "sweet spot" where I can resize the window to a point where "Home", "About" and "Search" are shown as when I clicked the button, even when I don't clicked the button. They don't disappear even if I click the button. (1920*1080, for me this spot seems to be around 990*x)

Down to 540*x I can see the button (in it's full size), below that it gets cut and disappears. As long as I can see a part of the button I can click it and the menu appears. Firefox does not allow me to scroll vertically. (There's no scrollbar)

Maybe it's some kind of bug.

comment:3 Changed 7 years ago by karsten

Priority: criticalnormal

I think this is a feature to avoid cutting off navigation bar entries in longer navigation bars than ours on mobile devices or smaller windows. Admitted, it's not pretty. Setting priority to normal though. Not sure what the right fix is.

comment:4 Changed 7 years ago by gsathya

This is the because of the "Responsive" design paradigm twitter bootstrap uses. Basically you use the same CSS for all screen sizes. 

comment:5 Changed 7 years ago by mno

Cc: m@… added

I just encountered the same problem on iPhone. I did eventually figure out the three-stripes button, but it is confusing because the text says "enter your search in the above box to get started" but there is no such box initially. The text should be reworded to "click the three stripes above to get started" if it's not going to show the search box.

Changed 7 years ago by mno

Attachment: photo.PNG added

screenshot on iPhone

comment:6 Changed 7 years ago by karsten

Status: newneeds_review

I think an easy fix would be to remove both the "Home" and the "About" link from the navigation bar and move the search field to the non-collapsing part of it. The result would be that there won't be a three stripes button anymore, and the search bar would move below the "Tor Status beta" logo when shrinking the browser window.

We don't really need a "Home" link, because the actual starting point of Atlas is its search bar (the only thing the "Home" page does is tell users to use the search field in the navbar), and because there's a link to the start page behind the "Tor Status beta" image. And the "About" link can as well be in the "secondary navbar" in the footer, along with links to source code, bug tracker, and contact.

Another fix, which requires more coding, would be to remove the navigation bar, add a big search field to the main page, and put a small search field at the top of the other pages. Think Google. But anyway, I think the easy fix is fine to resolve this ticket.

For the easy fix, please review branch task-6945 in my public repository. Thanks!

comment:7 in reply to:  6 Changed 7 years ago by hellais

Replying to karsten:

I think an easy fix would be to remove both the "Home" and the "About" link from the navigation bar and move the search field to the non-collapsing part of it. The result would be that there won't be a three stripes button anymore, and the search bar would move below the "Tor Status beta" logo when shrinking the browser window.

We don't really need a "Home" link, because the actual starting point of Atlas is its search bar (the only thing the "Home" page does is tell users to use the search field in the navbar), and because there's a link to the start page behind the "Tor Status beta" image. And the "About" link can as well be in the "secondary navbar" in the footer, along with links to source code, bug tracker, and contact.

Another fix, which requires more coding, would be to remove the navigation bar, add a big search field to the main page, and put a small search field at the top of the other pages. Think Google. But anyway, I think the easy fix is fine to resolve this ticket.

For the easy fix, please review branch task-6945 in my public repository. Thanks!

This looks good to me.

I agree that the home button is redundant. Less is more.

comment:8 Changed 7 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Merged and deployed. Closing. Thanks!

Note: See TracTickets for help on using tickets.