Opened 7 years ago

Closed 7 years ago

#6982 closed enhancement (implemented)

Support Bitrig, an OpenBSD fork

Reported by: dhill Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The following patch allows Tor to recognize Bitrig, an OpenBSD fork.

Child Tickets

Attachments (1)

tor-bitrig.diff (2.0 KB) - added by dhill 7 years ago.
Bitrig patch

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by dhill

Attachment: tor-bitrig.diff added

Bitrig patch

comment:1 Changed 7 years ago by nickm

Component: - Select a componentTor Relay
Milestone: Tor: 0.2.4.x-final
Priority: normalminor

I wonder if it might not make just as much sense to open bugs in the Bitrig bugtracker: "Make the system headers buildable with -Wredundant-decls" and "Add a s6_addr16 to in6_addr": Doing that would solve not only the build issue with Tor, but with various other projects as well.

(I'm cool with applying that part if bitrig can't fix their problems there.)

Certainly, the libevent workaround should be unneeded: if bitrig is shipping Libevent 1.3b, that would be really weird.

comment:2 Changed 7 years ago by nickm

Status: newneeds_review

comment:3 Changed 7 years ago by rransom

Why does Bitrig not define __OpenBSD__?

comment:4 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor

comment:6 Changed 7 years ago by arma

Status: needs_reviewneeds_information

comment:7 in reply to:  3 Changed 7 years ago by dhill

Replying to rransom:

Why does Bitrig not define __OpenBSD__?

It currently does, but may not in the future.

comment:8 in reply to:  1 Changed 7 years ago by dhill

Status: needs_informationnew

Replying to nickm:

I wonder if it might not make just as much sense to open bugs in the Bitrig bugtracker: "Make the system headers buildable with -Wredundant-decls" and "Add a s6_addr16 to in6_addr": Doing that would solve not only the build issue with Tor, but with various other projects as well.

(I'm cool with applying that part if bitrig can't fix their problems there.)

Certainly, the libevent workaround should be unneeded: if bitrig is shipping Libevent 1.3b, that would be really weird.

I have changed the tor package to build against libevent2, so the workaround is not really needed.

If you want to exclude those source changes, but just do the configure* patches, that should be sufficient for now, since currently, Bitrig does indeed define OpenBSD

comment:9 Changed 7 years ago by nickm

Resolution: implemented
Status: newclosed

Okay, merged the configure.ac part of the patch as d92d3f33356af002892ba5754d9d36cc4504c95f. Thanks!

Note: See TracTickets for help on using tickets.