Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6997 closed defect (implemented)

tor --version should imply --quiet

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: easy tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by arma)

$ src/or/tor --version
Sep 29 12:34:31.993 [notice] Tor v0.2.4.3-alpha-dev (git-b9c86948e4f4f0af) running on Linux with Libevent 2.0.19-stable and OpenSSL 1.0.1c.
Sep 29 12:34:31.994 [notice] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Sep 29 12:34:31.994 [notice] This version is not a stable Tor release. Expect more bugs than usual.
Tor version 0.2.4.3-alpha-dev (git-b9c86948e4f4f0af).

$ src/or/tor --version --quiet
Tor version 0.2.4.3-alpha-dev (git-b9c86948e4f4f0af).

Noticed from #6996.

Child Tickets

Attachments (2)

ticket6997.patch (426 bytes) - added by maker 7 years ago.
ticket6997.1.patch (678 bytes) - added by maker 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by arma

Description: modified (diff)

comment:2 Changed 7 years ago by arma

Keywords: easy added

Changed 7 years ago by maker

Attachment: ticket6997.patch added

comment:3 Changed 7 years ago by maker

Status: newneeds_review

Changed 7 years ago by maker

Attachment: ticket6997.1.patch added

comment:4 Changed 7 years ago by maker

Updating with Changelog.

< armadev> now i want to help you be able to write tor changes files too. :)

comment:5 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Tweaked and applied!

Here are some suggestions for your next patch:

  • The "git format-patch" tool generates output that includes an author line and a commit message, which makes it faster for me to merge the patch.
  • Please try to match the indentation of the surrounding code. Tor's doc/HACKING file has the appropriate magic to make emacs and vim do this for you.
  • We try not to refer to ticket numbers in the Tor source--we want the source and the documentation and the specifications to be the guide to how Tor works, rather than a collection of closed tickets. (The exception is when we're talking about an unresolved issue -- in that case, the open ticket is where we should coordinate discussion of getting it diagnosed and fixed.)

Thanks again for the patch!

comment:6 Changed 7 years ago by nickm

Keywords: tor-client added

comment:7 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.