Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7021 closed defect (fixed)

compile error, tor_addr_parse(&addr, options->OutboundBindAddress)

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: ln5 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

src/or/dns.c: In function 'configure_nameservers':
src/or/dns.c:1215: error: passing argument 2 of 'tor_addr_parse' from incompatible pointer type
./src/common/address.h:187: note: expected 'const char *' but argument is of type 'struct config_line_t * const'
src/or/dns.c:1216: error: format '%s' expects type 'char *', but argument 5 has type 'struct config_line_t * const'
make[1]: *** [src/or/dns.o] Error 1
make[1]: Leaving directory `/home/tord/git'
make: *** [all] Error 2

The line is

   if (tor_addr_parse(&addr, options->OutboundBindAddress) < 0) {

Sounds like commit 1cbf45bed1 was incomplete?

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

Totally untested fix in branch "bug7021."

comment:2 Changed 7 years ago by arma

Resolution: fixed
Status: needs_reviewclosed

Fixing and merging.

We opened #7024 to note that we won't bind to outbound ipv6 addresses for connections to our ipv6 nameservers.

comment:3 Changed 7 years ago by ln5

Ouch. I didn't compile with HAVE_EVDNS_SET_DEFAULT_OUTGOING_BIND_ADDRESS defined. Bummer.

It'd be great if there was a way of rebuilding tor with all possible
combinations of tweaks enabled/disabled, within some reason ofc.

Or maybe I should just stop trusting the compiler to find those kinds
of changes and start grepping more when doing changes like that.

Note: See TracTickets for help on using tickets.