Opened 7 years ago

Closed 21 months ago

#7025 closed defect (wontfix)

Support Tor 0.2.3.x control port event keyword reordering

Reported by: mikeperry Owned by: aagbsn
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Normal Keywords: easy
Cc: #13630 Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

Right now, the bandwidth auths are not going to work with Tor 0.2.3.x because for some reason we needed to deliberately break the control-spec.txt by reordering keywords... #3679 attempted to fix this by rewriting all of our event parsing, but that caused strange issues with the bw auths.

We should just try to update the regex instead, as a simpler change.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by mikeperry

Description: modified (diff)
Keywords: easy added

comment:2 Changed 7 years ago by atagar

Component: TorctlTorflow

Description has the magic words 'bandwidth auths'. Reassigning to TorFlow.

comment:3 Changed 6 years ago by arma

moria1's bwauth is running Tor 0.2.4.10-alpha-dev

Is it broken?

comment:4 Changed 5 years ago by arma

It seems like maybe this bug is invalid now?

comment:5 Changed 5 years ago by mikeperry

No. It just didn't seem to break the bw auths as severely as I expected. If you look at your logs at info level (I think?), you can see all sorts of misparsed CIRC events. It turns out it didn't seem to alter the results too much. We hope...

comment:6 Changed 21 months ago by teor

Cc: #13630 added
Priority: HighMedium
Resolution: wontfix
Severity: Normal
Status: newclosed

We probably won't fix this in torflow, see #13630 for a replacement

Note: See TracTickets for help on using tickets.