Opened 7 years ago

Closed 7 years ago

#7039 closed defect (fixed)

Client reports wrong circuit destroy reason to controller after truncated relay cell

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When a client sends an extend cell, it gets converted to a create cell. If the relay refuses the create cell (e.g. its onion queue is full) it sends back a destroy. The relay that receives the destroy converts it into a truncated relay cell and sends it back, complete with the reason in the destroy cell.

The client then receives the truncated relay cell, and decides to tear down the circuit. But it discards the reason from the truncated relay cell, instead opting to declare that the circuit closed in all cases because of END_CIRC_REASON_OR_CONN_CLOSED.

We should use the reason from the truncated relay cell.

Child Tickets

Change History (2)

comment:1 Changed 7 years ago by arma

Status: newneeds_review

bug7039 in my arma

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Seems okay to me. Merging.

Note: See TracTickets for help on using tickets.