Opened 7 years ago

Closed 6 years ago

#7065 closed defect (fixed)

Path-bias detector log messages identify entry guards incorrectly

Reported by: rransom Owned by: mikeperry
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client 024-deferrable
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Multiple log messages in entry_guard_inc_first_hop_count identify entry guards using the format “nickname=fingerprint”. They should use either the format “nickname ($fingerprint)” or the same format as the control-port protocol uses.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-final

comment:2 Changed 6 years ago by nickm

Owner: set to mikeperry
Status: newassigned

comment:3 Changed 6 years ago by nickm

Keywords: 024-deferrable added

There are functions to pretty-print the format the control-port protocol uses.

comment:4 Changed 6 years ago by mikeperry

Status: assignedneeds_review

mikeperry/bug7065.

The control port helper functions require additional fixed-size stack buffers everywhere, which means tons of updates if we ever change the hash size. I opted for $%s and hex_str() because of this. I also fixed a microdesc log occurrence of the %s=%s convention.

comment:5 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

I have a slight preference for the control-port format ([$]fp[=~]nickname), but not enough to force this to be different in 0.2.4, or at any actual point, really.

If somebody really prefers the "verbose nickname" format, the right answer is to use functions that return it.

Tweaked the changes file and merged to 0.2.4. Thanks!

Note: See TracTickets for help on using tickets.