Opened 5 years ago

Closed 5 years ago

#7072 closed defect (fixed)

Undocumented microdescriptor 'directory-signature' field

Reported by: atagar Owned by:
Priority: High Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi, the 'directory-signature' lines in microdescriptor consensus appear to have an extra undocumented field...

From section 3.3 (Vote and consensus status documents):

"directory-signature" SP identity SP signing-key-digest NL Signature

If this was any different for microdescriptor consensuses then it should say so in section 3.6.2 (Microdescriptor consensus).

Example from my cached-consensus...

directory-signature 14C131DFC5C6F93646BE72FA1401C02A8DF2E8B4 BF112F1C6D5543CFD0A32215ACABD4197B5279AD
-----BEGIN SIGNATURE-----
LcLgOFLh2Hb4ryZGmNH/v4fsptOi50rUawZEG/bJlWhQDmWIFJQ21Jg+Nj/99ltv
ybT5i1HEpWhKjz8N3iqtB90y+B+dJ/fbjHmIIGxG3TW7Q8zfsxQhjlAz+f1u47o6
dHnnylzcUjhjJ7w2ybaFSTIfVO9WPXuerF+ypIq3mn4=
-----END SIGNATURE-----

Example from my cached-microdesc-consensus...

directory-signature sha256 14C131DFC5C6F93646BE72FA1401C02A8DF2E8B4 BF112F1C6D5543CFD0A32215ACABD4197B5279AD
-----BEGIN SIGNATURE-----
jPDohv36PoXQIuxNNd2IYvj/RiDuJkIGhOkm5qD8yLXZiUfdcFYOt6Druvub1T8g
GRpvMsMJz+/clNggMzaynlqfN1UCZAykk8v6gnpYz1pqyfNS/J+3SlnhfeNr604s
iRB7VKis9lw/QX/U8cOQAFIhvAAdEZM7UGyhQ92ikbQ=
-----END SIGNATURE-----

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by atagar

Accounting for this difference in stem's parser and added a unit test for it...
https://gitweb.torproject.org/user/atagar/stem.git/commitdiff/e9374ba4bfc1ec9df01ff89bea63a6794cd1923d

comment:2 Changed 5 years ago by nickm

Keywords: tor-auth spec added
Milestone: Tor: 0.2.4.x-final
Priority: normalmajor

comment:3 Changed 5 years ago by nickm

Resolution: fixed
Status: newclosed

Fixed in 96427e8daa30e68d1b3cba13220fea84a4e8e842

Note: See TracTickets for help on using tickets.