Opened 8 years ago

Closed 8 years ago

#7115 closed defect (fixed)

Fix compilation warnings under cparser/firm

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

See mail at https://lists.torproject.org/pipermail/tor-dev/2012-October/004094.html

I'm making a ticket for this, so that I can apply it 0.2.3 if we decide we need to.

(Do we need to? I think that building warning-free under a new compiler we didn't try before is something not to do in a stable series at this point in our understanding of the word "stable", but then again this is a wafer-thin patch.)

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by rransom

You wanted a compiler that would treat enum foo as a different type from int. Now you have one.

comment:2 Changed 8 years ago by nickm

Status: newneeds_review

comment:3 Changed 8 years ago by nickm

Part of this was #7116, which I merged.

comment:4 Changed 8 years ago by arma

I'm ok with either choice, but if we want to put it into 0.2.3, we should do so today.

comment:5 Changed 8 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

I don't think this is for 0.2.3.

comment:6 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Applied in e4821fa14de6d76219d4e5c1a320ba263bd5e46d ; it seems we applied the returnval fix a bit earlier.

Note: See TracTickets for help on using tickets.