Opened 8 years ago

Closed 8 years ago

#7116 closed defect (fixed)

differing return type in definition and declaration of dirserv_add_extrainfo

Reported by: schachmat Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: - Select a component Version: Tor: 0.2.4.3-alpha
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We're trying to compile Tor with cparser and got an error.

src/or/dirserv.c:803:1: error: declaration 'was_router_added_t
dirserv_add_extrainfo(extrainfo_t*, const char)' is incompatible with
'int dirserv_add_extrainfo(extrainfo_t*, const char
)' (declared at
line 96:12)

The attached patch fixes this error due to inconsistently declared a return type (once declared as 'enum', once as 'int').

Child Tickets

Attachments (1)

0001-fixed-differing-returntype-in-definition-and-declara.patch (1.1 KB) - added by schachmat 8 years ago.
patch to fix issue #7116

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by schachmat

patch to fix issue #7116

comment:1 Changed 8 years ago by nickm

Milestone: Tor: 0.2.4.x-final
Resolution: fixed
Status: newclosed

This looks okay; merged it. It would also be okay to do a broader range of commits to get cparser working in general. See #7115 for the ticket I opened yesterday about that.

Note: See TracTickets for help on using tickets.