Opened 7 years ago

Closed 6 years ago

#7143 closed defect (fixed)

we've started putting micro-revision.i in the root dir

Reported by: arma Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We used to write src/or/micro-revision.i.

Sometime since git 64676d05 (I think), we started writing just ./micro-revision.i instead.

I guess tor_main.c's "#include "micro-revision.i"" can find it in either place. But it finds the old one in src/or/ even if the newer one gets written to the root dir.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client added

comment:2 Changed 6 years ago by nickm

Priority: normalminor
Status: newneeds_review

I added a simple fix I like in branch "bug7143_v2" that just adds "src/or/micro-revision.i" to CLEANFILES so that "make clean" will remove it if it's still around.

There's also an approach I don't like in "bug7143_v1" that tries to put it back in src/or again. That feels needless; I don't think we should do that.

Please review?

comment:3 Changed 6 years ago by andrea

The bug7143_v2 branch looks good to me.

comment:4 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

Note: See TracTickets for help on using tickets.