Opened 5 years ago

Closed 5 years ago

#7147 closed defect (fixed)

Don't use undefined socket.IPPROTO_IPV6 on Windows

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Alexandre reports this crash on Windows 7 with Python 2.7.3:

Traceback (most recent call last):
File "flashproxy-client", line 1003, in <module>
local_listen.append(listen_socket(addr))
File "flashproxy-client", line 464, in listen_socket
s.setsockopt(socket.IPPROTO_IPV6, socket.IPV6_V6ONLY, 1)
AttributeError: 'module' object has no attribute 'IPPROTO_IPV6'

He points to http://bugs.python.org/issue6926. We can safely skip this statement on Windows because IPV6_V6ONLY is the default for Windows sockets.

Child Tickets

Attachments (1)

ticket#7147.patch (1.2 KB) - added by cypherpunks 5 years ago.
Patch catches AttributeError and passes. Comment provides short explanation and links to Python bug list.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by cypherpunks

Attachment: ticket#7147.patch added

Patch catches AttributeError and passes. Comment provides short explanation and links to Python bug list.

comment:1 Changed 5 years ago by dcf

Patch looks good, applied.

comment:2 Changed 5 years ago by dcf

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.