Opened 6 years ago

Last modified 3 months ago

#7174 new project

Refactor node_t and router lists to make it easier to identify bugs

Reported by: karsten Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: SponsorZ, tor-client, needs-analysis refactor technical-debt stability
Cc: arma, nickm, andrea Actual Points:
Parent ID: #27248 Points: 4
Reviewer: Sponsor:

Description

Roger suspects that refactoring our node_t and router lists may make it easier to identify bugs like #1776. He also wonders whether the shift to microdescs has made things easier (or maybe even made #1776 go away).

Child Tickets

Change History (10)

comment:1 Changed 6 years ago by nickm

Keywords: tor-client added
Milestone: Tor: unspecified
Status: newneeds_information

I'd like to know what refactoring Roger has in mind; this ticket doesn't have enough info to tell what Roger would like to have happen.

comment:2 Changed 6 years ago by arma

#1776 happens because our "accept descriptor, store descriptor in one of several descriptor lists, expire descriptor, expire descriptor by moving it to a different descriptor list" logic is too complex. Part of that complexity is because it is invoked from too many different places in the code, probably inconsistently.

Is there some way we can simplify the logic, or at least who asks it to do which things, to make it easier to find out what this bug is, and to reduce the chances of further bugs like it?

comment:3 Changed 3 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.2.8.x-final

comment:4 Changed 3 years ago by nickm

Keywords: needs-analysis added
Points: medium

comment:5 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 261 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "needs_revision" and "needs_information" tickets, looking for things to move to ???.

Note that in most cases, if these tickets get the requested revisions done in time for the 0.2.8 merge window, they could get considered for review and merge in 0.2.8.

comment:6 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 22 months ago by nickm

Keywords: refactor technical-debt stability added
Points: medium4
Severity: Normal
Status: needs_informationnew

comment:10 Changed 3 months ago by teor

Parent ID: #27248

#27248 might fix this, or at least make it a lot easier.

Note: See TracTickets for help on using tickets.