Opened 6 years ago

Last modified 3 months ago

#7193 new enhancement

Tor's sybil protection doesn't consider IPv6

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, intro, tor-dirauth security sybil
Cc: tyseom Actual Points:
Parent ID: #24403 Points: small
Reviewer: Sponsor:

Description

Some bugs:

get_possible_sybil_list() doesn't consider IPv6 addresses at all.

clear_status_flags_on_sybil() doesn't clear ipv6_addr (and maybe more flags).

Also, maybe we could add a log_notice or log_info to mention if and which relays were found to be part of a Sybil attack.

Finally (and this is a minor bug), in get_possible_sybil_list() we assume that max_with_same_addr < max_with_same_addr_on_authority, which is true in the current tor network, but maybe it shouldn't be an inherent property of the source code.

Child Tickets

Change History (17)

comment:1 Changed 6 years ago by ln5

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

The IPv6 equivalent of an IPv4 /32 is a /64. We could have auths
reject multiple (more than AuthDirMaxServersPerAddr) IPv6 OR ports
with matching upper 64 bits. While the general abundance of IPv6
addresses might make this a bit toothless it shouldn't hurt.

Note that clients are not using IPv6 OR ports by default yet.

Moving to 0.2.4.x-final -- 0.2.3 dir auths don't handle IPv6 OR ports.

comment:2 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final
Type: defectenhancement

Since clients aren't handling IPv4 by default, and since you can't be a public server without an IPv4 address, I *think* this is not urgent for for 0.2.4.

comment:3 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.8.x-final

comment:5 Changed 3 years ago by nickm

Points: small

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final
Severity: Normal

This could be in 0.2.9.

comment:7 Changed 3 years ago by teor

We should probably do this in 0.2.9 if the IPv6 client bootstrap in #17840 gets merged in 0.2.8.

comment:8 Changed 3 years ago by nickm

Keywords: intro added

comment:9 Changed 3 years ago by tyseom

Cc: tyseom added

comment:10 Changed 3 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:11 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:12 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:13 Changed 19 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:14 Changed 19 months ago by dgoulet

Keywords: tor-dirauth added; tor-auth removed

Turns out that tor-auth is for directory authority so make it clearer with tor-dirauth

comment:15 Changed 19 months ago by nickm

Keywords: security sybil added

comment:16 Changed 13 months ago by teor

We need to do #24393 before we do this.

comment:17 Changed 3 months ago by teor

Parent ID: #24403
Note: See TracTickets for help on using tickets.