Opened 8 years ago

Closed 8 years ago

#7195 closed defect (fixed)

Add a helpful warning log when a managed proxy dies during configuration

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: pt
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In 64b2a64310a66a3e22403917ecdef38263ba0483 I accidentally removed some warnings logs that helped users realize that their managed proxy died.

Let's add them back.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by asn

Please see branch bug7195 in https://git.torproject.org/user/asn/tor.git.

It's OK to use switch on an enum, right? Or does comment:9:ticket:5070 complicate things?
I see bandwidth_weight_rule_to_string() doing it too, so I guess it's OK.

comment:2 Changed 8 years ago by arma

Status: newneeds_review

comment:3 Changed 8 years ago by nickm

Looks mostly okay, but I'm not sure about the message itself. What is the user supposed to do about this? The old message was,

"-      log_warn(LD_GENERAL, "Our communication channel with the managed proxy "
-               "'%s' closed. Most probably application stopped running.",
-               mp->argv[0]);"

which at least let you know, "Hey, there's a problem, maybe the managed proxy died."

But the new message is,

+      log_warn(LD_GENERAL, "The communication stream of managed proxy '%s' "
+               "is '%s'. The managed proxy will be destroyed.",
+               mp->argv[0], stream_status_to_string(stream_status));

which implies that Tor is going to destroy something (scary!) and doesn't really tell the user what happened.

IOW, what do we want people who see this message to know or do? And how can we make a message that leads them to do that?

comment:4 in reply to:  3 Changed 8 years ago by asn

Yes, you are right. Thanks for the review.

Please check the branch again. Is it more helpful now?

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

much better; merging; thanks!

Note: See TracTickets for help on using tickets.