Stem no longer supports python versions less than 2.7

added component::archived/stem owner::atagar priority::medium reporter::eoinof resolution::fixed status::closed type::defect labels

Hi eoinof, thanks for the catch! I'm planning to set up a continuing testing infrastructure for 2.5, 2.7, and 3.3 so we can catch these compatibility issues sooner but that's still a ways down the road.

The OrderedDict was only added in python 2.7

Damn, that's annoying. I'll look into making our own.

How were you using Stem (and Python<2.7)?

How were you using Stem (and Python<2.7)?

I don't understand your question. Copies of python 2.5 are still floating around. Iirc CentOS is actually still on 2.4 (though that's backward enough that I'm not supporting it).

In my case I downloaded stem to osx and tried to run the unit tests. I'm just looking around tor a bit.. :D

The reason I filed a bug report was that the code 'suggests' that stem supports python versions 2.5 and above.. https://gitweb.torproject.org/stem.git/blob/refs/heads/master:/stem/prereq.py

Trac:
Username: eoinof

stem supports python versions 2.5 and above..

Yup, that's my aim. If you look around the code you'll find lots of hacks to support 2.5. For instance...

https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/util/enum.py#l117 https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/control.py#l108 https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/util/log.py#l155 https://gitweb.torproject.org/stem.git/blob/HEAD:/stem/descriptor/reader.py#l88

I was actually gonna ask if you were planning to support python 3 as well as 2.x ? You'll need to do some work on exceptions..

Trac:
Username: eoinof

I was actually gonna ask if you were planning to support python 3 as well as 2.x ?

Yup, I am. Look for "Arc from Python" on...

http://www.atagar.com/arm/log.php

You'll need to do some work on exceptions..

Not necessary. By including a 2to3 conversion as part of the build we can support both the 2.x and 3.x series. Here's the setup.py that I wrote during the summit...


from stem import __version__, \
                 __author__, \
                 __contact__, \
                 __url__, \
                 __license__

from distutils.core import setup

try:
  from distutils.command.build_py import build_py_2to3 as build_py
except ImportError:
  from distutils.command.build_py import build_py

setup(name = 'stem',
      version = __version__,
      description = 'Controller library for tor',
      license = __license__,
      author = __author__,
      author_email = __contact__,
      url = __url__,
      packages = ['stem', 'stem.descriptor', 'stem.response', 'stem.util'],
      cmdclass = {'build_py': build_py},
)

It seems to work (I'm able to use stem via python 3 with the build output), but I haven't pushed this setup.py yet since I haven't tied in to stem's tests yet. I'd like to do that first to better validate the results...

Just pushed the spelling corrections that I mentioned on 'https://trac.torproject.org/7245' along with an overhaul of stem's API docs. You might find them to be a bit more readable now...

https://stem.readthedocs.org/en/latest/

Python 2.5 is unavailable in my apt repositories, but snagged 2.6 and fixed both this and another compatibility issue...

https://gitweb.torproject.org/stem.git/commitdiff/b09de10 https://gitweb.torproject.org/stem.git/commitdiff/aac44fe

Thanks for the catch! -Damian

Trac:
Status: new to closed
Resolution: N/A to fixed

closed

Stem no longer supports python versions less than 2.7

Child items 0

Activity