Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7246 closed enhancement (implemented)

Unit test script summary could display info on whether tests were skipped.

Reported by: eoinof Owned by: atagar
Priority: Low Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When you run the unit tests the only indication that a test has been skipped is the output that flies by on the screen!

Since it is not really a proper test pass if some tests are skipped it might be useful to display a relevant message in the test run summary ?

I've put a suggested implementation here:
https://github.com/eoinof/stem/commit/249d9bd3809f27bc9dd99135e767cd292644ec00

Eoin.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by atagar

  • Resolution set to implemented
  • Status changed from new to closed

comment:2 follow-up: Changed 5 years ago by atagar

On a side note if you wanted this to work for python 2.5 and 2.6 then you could count the calls to skip() instead...

https://gitweb.torproject.org/stem.git/blob/HEAD:/test/runner.py#l105

comment:3 in reply to: ↑ 2 Changed 5 years ago by eoinof

Replying to atagar:

On a side note if you wanted this to work for python 2.5 and 2.6 then you could count the calls to skip() instead...

https://gitweb.torproject.org/stem.git/blob/HEAD:/test/runner.py#l105

ah, I'll take a look.

Note: See TracTickets for help on using tickets.