Opened 7 years ago

Closed 7 years ago

#7263 closed enhancement (fixed)

test.check_whitespace.get_issues not being used correctly.

Reported by: eoinof Owned by: atagar
Priority: Low Milestone:
Component: Archived/Stem Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


This checkin expanded the scope of the check_whitespace function

However the arg passed can only be a path, not a filename so the 3rd line of this checkin has no effect.

A easier approach would be to scan all python files in the project?
I've made this change here:

And fixed 2 whitespace issues in here:

Child Tickets

Change History (1)

comment:1 Changed 7 years ago by atagar

Resolution: fixed
Status: newclosed

Hi Eoin. Great catch! I'd rather not go with a check of '.' for a couple reasons...

  • Not everything in our directory might be part of the library. For instance, I have a couple scratch scripts I've used for testing.
  • When we have a our build directory will be in here too, and I don't really want to check its contents.

Made an alternate fix for this...

... and also corrected another bug in this code...

Thanks! -Damian

Note: See TracTickets for help on using tickets.