Opened 7 years ago

Closed 7 years ago

#7280 closed defect (fixed)

Fix tor-fw-helper-natpmp.c on Windows

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client 023-backport
Cc: ioerror Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On tor-dev ( https://lists.torproject.org/pipermail/tor-dev/2012-November/004128.html ), Gisle Vanem reports:

The code in tools\tor-fw-helper\tor-fw-helper-natpmp.c does
things wrong on Winsock where e.g. errno isn't set on 
socket-errors and 'fd' is (always?) >= FD_SETSIZE. 
Patch attached.

I'm attaching the patch here and making a ticket. This is an 0.2.3 bug, so marking as possible for that milestone.

Child Tickets

Attachments (1)

diffs-1.txt (2.0 KB) - added by nickm 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by nickm

Attachment: diffs-1.txt added

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

comment:2 Changed 7 years ago by nickm

Keywords: 023-backport added
Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Applied to 0.2.4.x. I don't think this makes sense for an 0.2.3 backport any longer. Closing. Thanks!

Note: See TracTickets for help on using tickets.