Opened 7 years ago

Closed 7 years ago

#7293 closed defect (fixed)

tor current compile breakage connection_edge.c (inc pfvar.h)

Reported by: yancm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

with tor current from git On NetBSD 5_current, i386...tor compile breaks:

From git://git.torproject.org/git/tor

ae99fc1..05194cc master -> origin/master

Updating ae99fc1..05194cc
Fast-forward

changes/ewma_policy_c99 | 3 +++
src/or/circuitmux_ewma.c | 19 ++++++++++---------
2 files changed, 13 insertions(+), 9 deletions(-)
create mode 100644 changes/ewma_policy_c99

BSDBox 144 # make
make all-am

CC src/or/circuitmux_ewma.o
CC src/or/connection_edge.o

In file included from src/or/connection_edge.c:49:
/usr/include/net/pfvar.h:419: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/net/pfvar.h:496: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/net/pfvar.h:993: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/net/pfvar.h:1007: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
* Error code 1

Stop.
make: stopped in /usr/local/src/tor
* Error code 1

Stop.
make: stopped in /usr/local/src/tor

Child Tickets

Attachments (1)

0001-Add-an-SLIST_ENTRY-definition-back-on-non-win32.patch (701 bytes) - added by nickm 7 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by nickm

Component: - Select a componentTor
Keywords: tor-client added
Milestone: Tor: 0.2.4.x-final

Probably related to the tor_queue.h we added.

comment:2 Changed 7 years ago by nickm

Status: newneeds_review

Does the attached patch (untested on openbsd) fix the issue for you?

comment:3 Changed 7 years ago by yancm

Yes, the patch does seem to address the issue.

comment:4 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Great; merged it to master.

Note: See TracTickets for help on using tickets.