Opened 8 years ago

Closed 8 years ago

#7310 closed defect (fixed)

nmake script LIBS variable uses .a instead of .lib

Reported by: ultramage Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: msvc nmake tor-client
Cc: Actual Points:
Parent ID: #7754 Points:
Reviewer: Sponsor:

Description

In src/or/Makefile.nmake the LIBS variable refernces third-party libraries libevent.a, libcrypto.a, libssl.a and libz.a. This file extension confuses the MSVC linker, which will print warnings about unknown type and "assuming". Using the .lib file extension is more appropriate since this is what the linked projects use. Curiously enough, src/test/Makefile.nmake already has this 'fix', so I'm not sure what happened there.

PS: there's a naming inconsistency: libcrypto -> libeay32, libssl -> ssleay32, libz -> zlib
these are easily worked around using symlinks, but it makes me wonder if openssl has a toggle for the legacy/defunct eay product imitation.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by ultramage

Component: - Select a componentTor

comment:2 Changed 8 years ago by nickm

Keywords: msvc nmake tor-client added
Milestone: Tor: 0.2.4.x-final

comment:3 Changed 8 years ago by nickm

Parent ID: #7754

comment:4 Changed 8 years ago by nickm

Status: newneeds_review

This is in the 024_msvc branch.

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged a fix for this into master as of b998431a33db2b.

Note: See TracTickets for help on using tickets.