Opened 8 years ago

Closed 8 years ago

#7312 closed defect (fixed)

nmake scripts missing include ../ext path

Reported by: ultramage Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: msvc nmake tor-client
Cc: Actual Points:
Parent ID: #7754 Points:
Reviewer: Sponsor:

Description

All 0.2.4+ nmake makefiles need to be updated to match the change that split off external code to the ../ext directory. In particular, since all of them are used in the main codebase via #include "..." directives, ext needs to be in the include path.

The fix is easy, just append
/I ..\ext
to every CFLAGS.

PS: an even cleaner way would be to split off an INCLUDES variable to hold the include paths. Maybe even use some $() magic to tack on the /I part after-the-fact.

Child Tickets

Change History (5)

comment:1 Changed 8 years ago by nickm

Keywords: msvc nmake tor-client added
Milestone: Tor: 0.2.4.x-final

comment:2 Changed 8 years ago by nickm

Parent ID: #7754

comment:3 Changed 8 years ago by nickm

This is in the 024_msvc branch.

comment:4 Changed 8 years ago by nickm

Status: newneeds_review

comment:5 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged a fix for this into master as of b998431a33db2b.

Note: See TracTickets for help on using tickets.