Opened 7 years ago

Closed 7 years ago

#7313 closed defect (fixed)

msvc compilation error for libevent2, missing HAVE_EVENT2_DNS_H

Reported by: ultramage Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: msvc tor-client
Cc: Actual Points:
Parent ID: #7754 Points:
Reviewer: Sponsor:

Description

If we assume MSVC builds have to use the latest available libevent version (no reason not to since it has to be built from source anyway), then src/win32/orconfig.h requires an additional line:

#define HAVE_EVENT2_DNS_H

otherwise mixing of old and new version code happens, and

3>libtor.lib(dns.obj) : error LNK2019: unresolved external symbol _evdns_set_default_outgoing_bind_address referenced in function _configure_nameservers
3>libtor.lib(dns.obj) : error LNK2019: unresolved external symbol _evtimer_add referenced in function _dns_launch_correctness_checks
3>libtor.lib(dns.obj) : error LNK2019: unresolved external symbol _evtimer_new referenced in function _dns_launch_correctness_checks

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client added
Milestone: Tor: 0.2.4.x-final

comment:2 Changed 7 years ago by nickm

Parent ID: #7754

comment:3 Changed 7 years ago by nickm

This is in the 024_msvc branch,

comment:4 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Merged a fix for this into master as of b998431a33db2b.

Note: See TracTickets for help on using tickets.