Opened 7 years ago

Closed 4 years ago

Last modified 4 years ago

#7356 closed enhancement (implemented)

Make channel state test macros

Reported by: andrea Owned by: rl1987
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.5-alpha
Severity: Keywords: tor-relay easy 024-deferrable
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We check for conditions like if (!(circ->n_chan->state == CHANNEL_STATE_CLOSING
circ->n_chan->state == CHANNEL_STATE_CLOSED circ->n_chan->state == CHANNEL_STATE_ERROR)) a lot; there should be more concise test macros.

Child Tickets

Change History (12)

comment:1 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:2 Changed 6 years ago by nickm

Keywords: easy 024-deferrable added
Status: newassigned

comment:3 Changed 6 years ago by andrea

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:4 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:5 Changed 5 years ago by rl1987

Owner: changed from andrea to rl1987
Status: assignedaccepted

comment:6 Changed 5 years ago by rl1987

Status: acceptedneeds_review

comment:7 Changed 5 years ago by nickm_mobile

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final

Cool; code! I'll check this out : could you also check it out, Andrea?

comment:8 Changed 4 years ago by nickm

18:20 < nickm> ok. in that case, what 7356 needs is somebody to make sure , in 
               every case, that the old code matches the new code (in behavior)

comment:9 Changed 4 years ago by rl1987

Fixed one semantic error and one wrong comment. teor says everything else is okay.

Last edited 4 years ago by rl1987 (previous) (diff)

comment:10 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Squashed and merged!

comment:11 Changed 4 years ago by cypherpunks

This is called a 'simplification' but it's more like another layer of indirection and a horrible name for a macro.

comment:12 Changed 4 years ago by nickm

Can you suggest a better name?

Note: See TracTickets for help on using tickets.