Opened 7 years ago

Closed 7 years ago

#7420 closed defect (fixed)

tor-resolve now needs to pull in libor-crypto, openssl, etc etc

Reported by: arma Owned by:
Priority: High Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When building 0.2.3 or master after the #7352 merge, my tor-resolve won't build:

  /home/tord/git/src/common/util.c:4017: undefined reference to `memwipe'

The offending line is:

  memwipe(process_handle, 0x0f, sizeof(process_handle_t));

Maybe we'd be happier campers just making that memwipe into a memset?

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by arma

Cc: nickm added

comment:2 Changed 7 years ago by arma

(I also realize that we're going to need another 0.2.3 rc if we leave the #7352 branch in 0.2.3.)

comment:3 Changed 7 years ago by nickm

arma: also, if you make that memwipe into a memset, does it compile then or does it complain about something else?

comment:4 Changed 7 years ago by arma

It compiles when I fix just that memwipe to be a memset (moria1 has been running with git master, plus that fix, for the past few hours under valgrind. No complaints so far.)

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Whoops. I fixed this as e567b4482a1473f586a8549d9311d989c2335172 but forgot to close the ticket. Sorry!

Note: See TracTickets for help on using tickets.