Opened 12 years ago

Closed 9 years ago

#747 closed defect (duplicate)

maximized window gets resized with Tor enabled

Reported by: arno Owned by:
Priority: Very High Milestone:
Component: TorBrowserButton Version: 1.1
Severity: Keywords: MikePerryIteration20110630
Cc: arno, arma, mikeperry, Sebastian Actual Points: 1
Parent ID: Points: 3
Reviewer: Sponsor:

Description (last modified by mikeperry)

when I maximize (with my window manager) firefox, here is what I get:

but when I maximize it with tor enabled, here is what I get:

You can see that the bottom of the window does not appear. It looks like window's height is too big.
I've never experienced that behaviour before.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.0-dev.xpi.11 (319.3 KB) - added by mikeperry 12 years ago.
Torbutton with attempt at fullscreen detection

Download all attachments as: .zip

Change History (12)

comment:1 Changed 12 years ago by arno

I found it is because tor resizes window to a multiple of 50px.
I if disable corresponding preference, that behaviour disappears.

I think that bug is invalid.

comment:2 Changed 12 years ago by mikeperry

Actually I misunderstood. I actually coded the feature to check window.windowState and NOT operate on either
minimized or maximized windows. Firefox is incorrectly reporting window.windowState for maximized windows here.

We should file a firefox bug..

comment:3 Changed 12 years ago by arno

Firefox correctly reports when window is maximized. Problem occurs when window is fullscreen, which is a different state.
I opened a mozilla bug

comment:4 Changed 12 years ago by mikeperry

I've made an attempt at a workaround for this. I can't reproduce it exactly on my machine, but maybe this
will get it. Can you try the snapshot in the attachments tab by running:

firefox -jsconsole

from a command line and then paste me the output? It should print out a bunch of Torbutton NOTE level messages
(loglevel 4) about resizing the window.

Changed 12 years ago by mikeperry

Attachment: torbutton-1.2.0-dev.xpi.11 added

Torbutton with attempt at fullscreen detection

comment:5 Changed 11 years ago by Sebastian

r1eo| did anybody knows that torbutton returns non rounded screen.height for

maximized window, with all that individual toolbars and icon size crap it's
can be very unique without rounding. I guess it's already some bug number?

Sebastian| people had complained that their browser window was resized when

they were maximizing their browser

Sebastian| I think mikeperry might be unaware of the toolbar and icon size stuff

you just mentioned.

Sebastian| Shall I file a bug report for you?
r1eo| it's a bad feature :)
r1eo| people loodly complains, I think it needed look at this at least.

comment:6 Changed 10 years ago by mikeperry

Description: modified (diff)
Priority: minornormal

comment:7 Changed 10 years ago by mikeperry

Priority: normalcritical

Firefox claims this bug is now fixed upstream. Let's try implementing a detection mechanism. There's also a huge dup chain. Here are some other relevant bug numbers:

comment:8 Changed 9 years ago by mikeperry

Component: TorbuttonTorBrowserButton

comment:9 Changed 9 years ago by mikeperry

Keywords: MikePerryIteration20110612 added
Points: 3

If Firefox really fixed the root cause, this should be easy. I bet it's not though... Plus fixing it will require me using some crazy window manager like ratpoison..

comment:10 Changed 9 years ago by mikeperry

Keywords: MikePerryIteration20110630 added; MikePerryIteration20110612 removed

comment:11 Changed 9 years ago by mikeperry

Actual Points: 1
Resolution: Noneduplicate
Status: newclosed

I'm pretty sure the remaning cases of this are due only to #3506.

Note: See TracTickets for help on using tickets.