Opened 7 years ago

Closed 7 years ago

#7508 closed defect (fixed)

Stream purposes are undocumented

Reported by: atagar Owned by:
Priority: Very Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In general the control spec is pretty good about saying what event attributes indicate. One exception are stream purposes which are completely undocumented.

https://gitweb.torproject.org/torspec.git/blob/HEAD:/control-spec.txt#l1411

atagar@morrigan:~/Desktop/tor/torspec$ grep -R "UPLOAD_DESC" ./*
./control-spec.txt:      Purpose = "DIR_FETCH" / "UPLOAD_DESC" / "DNS_REQUEST" /

atagar@morrigan:~/Desktop/tor/torspec$ grep -R "DNS_REQUEST" ./*
./control-spec.txt:      Purpose = "DIR_FETCH" / "UPLOAD_DESC" / "DNS_REQUEST" /

... etc...

See the StreamStatus above for an example of a nice mapping between attributes and a description.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client spec added
Milestone: Tor: 0.2.4.x-final

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Should be fixed in e23a24a5c481805f1c8a4b4db04d7beee543f887

comment:3 Changed 7 years ago by atagar

Priority: normaltrivial
Resolution: fixed
Status: closedreopened

Thanks Nick! Minor thing, the 'DIR_UPLOAD' value isn't enumerated above...

Purpose = "DIR_FETCH" / "UPLOAD_DESC" / "DNS_REQUEST" /
          "USER" /  "DIRPORT_TEST"

https://gitweb.torproject.org/torspec.git/blob/e23a24a:/control-spec.txt#l1430

comment:4 Changed 7 years ago by nickm

Resolution: fixed
Status: reopenedclosed

Should be better in 36d7d050418c560cfda76899af449c363f55111e .

I also did a "git log -p src/or/control.c", and found no evidence that "UPLOAD_DESC" actually ever existed, so instead of calling it obsolete, I'm just removing it

Note: See TracTickets for help on using tickets.