"Configure controlport automatically" is mysteriously missing when Vidalia couldn't start Tor

When a Windows user is running Tor already and starts TBB, it fails to start Tor because Tor can't bind to 9050 / 9051. When this happens, Vidalia chooses not to display the "Configure controlport automatically" button on its Settings -> Advanced page.

The workaround for people who want to run multiple Tors is "close all your other Tors before starting TBB, and then tell TBB to switch to switch to auto". It would be good if Vidalia could handle this directly though -- i.e. if it failed to start Tor, still offer the option to switch Tor to auto.

A simpler approach that would still help here would be to leave the clickbox in, but grey it out if you don't want the user clicking it.

added component::archived/vidalia owner::chiiph priority::medium resolution::wontfix status::closed type::defect version::vidalia 0.2.20 labels

Trac:
Description: When a Windows user is running Tor already and start TBB, it fails to start Tor because Tor can't bind to 9050 / 9051. When this happens, Vidalia chooses not to display the "Configure controlport automatically" button on its Settings -> Advanced page.

The workaround for people who want to run multiple Tors is "close all your other Tors before starting TBB, and then tell TBB to switch to switch to auto". It would be good if Vidalia could handle this directly though -- i.e. if it failed to start Tor, still offer the option to switch Tor to auto.

A simpler approach that would still help here would be to leave the clickbox in, but grey it out if you don't want the user clicking it.

to

When a Windows user is running Tor already and starts TBB, it fails to start Tor because Tor can't bind to 9050 / 9051. When this happens, Vidalia chooses not to display the "Configure controlport automatically" button on its Settings -> Advanced page.

The workaround for people who want to run multiple Tors is "close all your other Tors before starting TBB, and then tell TBB to switch to switch to auto". It would be good if Vidalia could handle this directly though -- i.e. if it failed to start Tor, still offer the option to switch Tor to auto.

A simpler approach that would still help here would be to leave the clickbox in, but grey it out if you don't want the user clicking it.

I already had enough info to repro this bug. Vidalia hides this option if the Tor version is less than 0.2.2.26 and if Vidalia fails to connect to Tor then the default Tor version is 0, thus this behavior.

bug7514 on https://gitweb.evolvesoftware.cc/vidalia.git

Trac:
Status: new to needs_review

Trac:
0001-Show-Configure-ControlPort-Automatically-option.patch

Looks good.

A couple of minor things:

• You've got a typo in the second "IF"
• You should also add a changes file with the changelog entry for this patch. Check some of the existing ones, or the main changelog for reference on how to write them

Trac:
Status: needs_review to needs_revision

Updated patch. Branch bug7514-2 on https://gitweb.evolvesoftware.cc/vidalia.git

The comment in the code may be a little too verbose, so we can cut that down a little if you want. Patch to follow also.

Trac:
Status: needs_revision to needs_review

Trac:
0001-Show-Configure-ControlPort-Automatically-option.2.patch

I made bug7514-3 (patch below) after rereading arma's comment regarding disabling the option instead of hiding it. I'm not sure which one you prefer. From a usability point of view, only sometimes having the option may be confusing but hopefully no one is running such an old version of Tor so it shouldn't be an issue.

Trac:
0001-Show-Configure-ControlPort-Automatically-option.3.patch

Since the checkbox is unchecked when disabled, I think both options are good. If you go with the disabling you should change the changes file.

Trac:
Status: needs_review to needs_revision

Sure. I think it looks cleaner hidden but it's easier to troubleshoot if it's simply disabled. Updated the change log. bug7514-4 and following.

Trac:
Status: needs_revision to needs_review

Trac:
0001-Show-Configure-ControlPort-Automatically-option.4.patch

Have you tried having an old tor, starting Vidalia but not starting tor, then enabling the automatic control port, and finally starting tor? It should fail, because it never checks the version before setting this value. It works as it is right now, because the checkbox isn't displayed if Vidalia doesn't know anything about tor.

You should add version checking to prevent this situation.

Trac:
Status: needs_review to needs_revision

Closing because Vidalia is not much maintained these days.

Trac:
Resolution: N/A to wontfix
Status: needs_revision to closed

closed