Opened 7 years ago

Closed 7 years ago

#7592 closed defect (fixed)

Return from connection_exit_connect() if we failed to create CONNECTED payload

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

882b389668067a29bb539d0f5bd5cb2f83b93012 forgets to return from connection_exit_connect() if connected_cell_format_payload() fails:
https://gitweb.torproject.org/tor.git/blob/HEAD:/src/or/connection_edge.c#l2613

I'm not too familiar with the high-level logic of this code, but this looks buggy.

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by asn

Status: newneeds_review

Please see branch bug7592 in https://git.torproject.org/user/asn/tor.git.

comment:2 Changed 7 years ago by asn

Please see branch bug7592_take2 in https://git.torproject.org/user/asn/tor.git based on comments by nickm on IRC.

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks good ; merged

Note: See TracTickets for help on using tickets.