Opened 5 years ago

Closed 5 years ago

#7617 closed enhancement (implemented)

add unit tests for is_valid_circuit_id

Reported by: robinson Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords: test
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description


Child Tickets

Attachments (1)

0001-Add-unit-tests-for-is_valid_circuit_id-function.patch.gz (609 bytes) - added by robinson 5 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 years ago by atagar

Hi robinson. Like #7616 I'm having a bit of trouble applying this patch too (oddly 'git am' prompts me to resolve the conflict, but doesn't leave a conflict in my working tree to resolve). Pulling from a branch would make this far easier. :)

comment:2 Changed 5 years ago by robinson

Keywords: test added

I have uploaded a fixed patch. I believe a pull from a repo would have failed also, but you would have been able to see why. I will look into setting up a public repo, soon.

This version of the patch originates from the Stem main repo master branch, so should work correctly. The previous version was based in a context where I had modelines in each file to conform to the Stem project's white space policy. I moved that configuration to a single .kateconfig file.

comment:3 Changed 5 years ago by atagar

Resolution: implemented
Status: newclosed

Looks great! Pushed.

Note: See TracTickets for help on using tickets.