Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7619 closed defect (fixed)

GUARD event spec incomplete

Reported by: atagar Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The spec for the GUARD event type has a few issues...

  1. I'm not really sure what to expect for the 'Name' attribute. The spec says...
Name = The (possibly verbose) nickname of the guard affected.

I've listened for some and it seems to be a fingerprint...

650 GUARD ENTRY $5D0034A368E0ABAF663D21847E1C9B6CFA09752A BAD
650 GUARD ENTRY $071C2D9D0E03D75FF30DCCA850BB29CA4A4BB383 BAD
650 GUARD ENTRY $36B5DBA788246E8369DBAF58577C6BC044A9A374 NEW
650 GUARD ENTRY $071C2D9D0E03D75FF30DCCA850BB29CA4A4BB383 GOOD
650 GUARD ENTRY $5D0034A368E0ABAF663D21847E1C9B6CFA09752A GOOD

Is this either a "$[fingerprint]" or nickname? Something else?

  1. There's a TODO comment to explain the states.
  1. The 'Type' is simply described as...
Type = "ENTRY"

I'm guessing that this attribute is to allow guards to be used for other things in the future. If so then the spec should say so.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by nickm

Keywords: tor-spec added; spec removed

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-final

comment:3 Changed 7 years ago by nickm

Status: newneeds_review

Take a look at branch "bug7619" in my public repository.

comment:4 Changed 7 years ago by atagar

Looks great! My only minor nitpick is that...

Type = "ENTRY"

... should no longer be quoted since ENTRY is a type. Thanks for the clarifications!

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

I don't understand what you man by "since ENTRY is a type" ... the literal string "ENTRY" is one of the values that Type can take, so it should get quotes, I think?

I'm going to merge what I've got, and we can pick this nit further when we have a chance.

comment:6 Changed 7 years ago by atagar

Oops, my mistake. I misread it as 'entry = status', disregard.

Note: See TracTickets for help on using tickets.