Opened 5 years ago

Closed 5 years ago

#7622 closed defect (fixed)

Add -4 and -6 options to flashproxy-client and flashproxy-reg-http

Reported by: dcf Owned by: dcf
Priority: Medium Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

flashproxy-reg-email supports -4 and -6 options; if you're dual-stack, and you've configured IPv4 port forwarding, flashproxy-reg-email may connect to the SMTP server over IPv6 and register your IPv6 address, leading to confusion.

flashproxy-client should understand -4 and -6 and pass them to registration helpers that understand them. flashproxy-reg-http should use the same socket trick that flashproxy-reg-email uses.

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by dcf

Status: newneeds_revision

Referring to Jorge's changes at https://github.com/uyjco0/flashproxy/tree/bb7dcdea1e1a04ed8f25cfbc101fbc4f3cdf289b.

I applied the part of the patch referring to flashproxy-reg-http, but I want you to make some changes in the part for flashproxy-client.

Don't define a DEFAULT_ADDRESS_FAMILY in flashproxy-client. The default should be whatever the system default is, which depends on system configuration. In other words, let None be a setting, and then don't add -4 or -6 to any commands.

Don't add the "Trying to register using IPv4" outputs.

Check the indentation in the usage text.

comment:2 in reply to:  1 ; Changed 5 years ago by jct

Replying to dcf:

Referring to Jorge's changes at https://github.com/uyjco0/flashproxy/tree/bb7dcdea1e1a04ed8f25cfbc101fbc4f3cdf289b.

I applied the part of the patch referring to flashproxy-reg-http, but I want you to make some changes in the part for flashproxy-client.

Don't define a DEFAULT_ADDRESS_FAMILY in flashproxy-client. The default should be whatever the system default is, which depends on system configuration. In other words, let None be a setting, and then don't add -4 or -6 to any commands.

Don't add the "Trying to register using IPv4" outputs.

Check the indentation in the usage text.

Done!

comment:3 in reply to:  2 Changed 5 years ago by jct

Replying to jct:

Replying to dcf:

Referring to Jorge's changes at https://github.com/uyjco0/flashproxy/tree/bb7dcdea1e1a04ed8f25cfbc101fbc4f3cdf289b.

I applied the part of the patch referring to flashproxy-reg-http, but I want you to make some changes in the part for flashproxy-client.

Don't define a DEFAULT_ADDRESS_FAMILY in flashproxy-client. The default should be whatever the system default is, which depends on system configuration. In other words, let None be a setting, and then don't add -4 or -6 to any commands.

Don't add the "Trying to register using IPv4" outputs.

Check the indentation in the usage text.

Done!

I've changed the "flashproxy" repository in Github, so the current commit doing the above (and building over the patch already applied by David) is: https://github.com/uyjco0/flashproxy/commit/3988a6b87272705e37a57d1b7ea039181e75c021

comment:4 Changed 5 years ago by dcf

Resolution: fixed
Status: needs_revisionclosed

Thanks, this looks good. I have committed it.

Note: See TracTickets for help on using tickets.