Changes between Initial Version and Version 1 of Ticket #7646, comment 11


Ignore:
Timestamp:
Mar 26, 2014, 7:19:20 PM (6 years ago)
Author:
nickm
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7646, comment 11

    initial v1  
    11Actually... ug.
    22
    3 If I'm analyzing this right, the current behavior is just plain ugly. It takes the router status information, not from the node_t (where "our current opinion about the router" should be), but from the networkstatus_t (the thing we downloaded, which used to get modified with our opinions of node status, but which now is treated as immutable since we did the node_t refactor).  And then it writes it in the old, pre-microdescriptor format...whether it's microdescriptor data or not, so the microdescriptor digest.
     3If I'm analyzing this right, the current behavior is just plain ugly. It takes the router status information, not from the node_t (where "our current opinion about the router" should be), but from the networkstatus_t (the thing we downloaded, which used to get modified with our opinions of node status, but which now is treated as immutable since we did the node_t refactor).  And then it writes it in the old, pre-microdescriptor format...whether it's microdescriptor data or not, so the microdescriptor digest gets written out in the place that the descriptor digest should go, with its last 12 bytes omitted.
    44
    55Yuck yuck yuck.